Merge pull request #1486 from dbu/has-request

make hasRequest part of the AdminInterface

Admin/Admin.php

@@ -2160,8 +2160,7 @@ abstract class Admin implements AdminInterface, DomainObjectInterface
     }
 
     /**
-     *
-     * @return boolean true if the request object is linked to the Admin
+     * {@inheritdoc}
      */
     public function hasRequest()
     {

Admin/AdminInterface.php

@@ -138,9 +138,17 @@ interface AdminInterface
 
     /**
      * @return \Symfony\Component\HttpFoundation\Request
+     *
+     * @throws \RuntimeException if no request is set.
      */
     public function getRequest();
 
+    /**
+     * @return boolean true if a request object is linked to this Admin, false
+     *      otherwise.
+     */
+    public function hasRequest();
+
     /**
      *
      * @return string

CHANGELOG.md

@@ -10,6 +10,16 @@ CHANGELOG
       public function alterNewInstance(AdminInterface $admin, $object)
       {}
 
+* [BC BREAK] added hasRequest to the AdminInterface
+  If you do not extend the Admin class, you need to add a hasRequest method to
+  your admin like this (depending on how you handle the request you return in
+  getRequest:
+
+      public function hasRequest()
+      {
+          return null !== $this->request;
+      }
+
 ### 2013-07-05
 
 *  Remove qTip