Selaa lähdekoodia

Execute Admin methods after the object is defined

The Admin.js file first sets up event listeners. When loaded
asynchronously, document ready may have already fired, causing instant
execution and a JS error as the Admin object has not been defined.

Moving the event after the Admin object definition fixes this problem.
Andy Thorne 10 vuotta sitten
vanhempi
commit
5945e399e7
1 muutettua tiedostoa jossa 17 lisäystä ja 17 poistoa
  1. 17 17
      Resources/public/Admin.js

+ 17 - 17
Resources/public/Admin.js

@@ -9,23 +9,6 @@
 
 
  */
  */
 
 
-jQuery(document).ready(function() {
-    jQuery('html').removeClass('no-js');
-    if (window.SONATA_CONFIG && window.SONATA_CONFIG.CONFIRM_EXIT) {
-        jQuery('.sonata-ba-form form').each(function () { jQuery(this).confirmExit(); });
-    }
-
-    Admin.setup_per_page_switcher(document);
-    Admin.setup_collection_buttons(document);
-    Admin.shared_setup(document);
-});
-
-jQuery(document).on('sonata-admin-append-form-element', function(e) {
-    Admin.setup_select2(e.target);
-    Admin.setup_icheck(e.target);
-    Admin.setup_collection_counter(e.target);
-});
-
 var Admin = {
 var Admin = {
 
 
     collectionCounters: [],
     collectionCounters: [],
@@ -644,3 +627,20 @@ var Admin = {
         };
         };
     }
     }
 };
 };
+
+jQuery(document).ready(function() {
+    jQuery('html').removeClass('no-js');
+    if (window.SONATA_CONFIG && window.SONATA_CONFIG.CONFIRM_EXIT) {
+        jQuery('.sonata-ba-form form').each(function () { jQuery(this).confirmExit(); });
+    }
+
+    Admin.setup_per_page_switcher(document);
+    Admin.setup_collection_buttons(document);
+    Admin.shared_setup(document);
+});
+
+jQuery(document).on('sonata-admin-append-form-element', function(e) {
+    Admin.setup_select2(e.target);
+    Admin.setup_icheck(e.target);
+    Admin.setup_collection_counter(e.target);
+});