Browse Source

Removed the use of $request->get() in the HelperController

Parameters are always passed through GET parameters so using
$request->query->get() to access them has better performances
Christophe Coevoet 14 years ago
parent
commit
9e262a343c
1 changed files with 10 additions and 10 deletions
  1. 10 10
      Controller/HelperController.php

+ 10 - 10
Controller/HelperController.php

@@ -30,9 +30,9 @@ class HelperController extends Controller
     {
         $helper     = $this->getAdminHelper();
         $request    = $this->get('request');
-        $code       = $request->get('code');
-        $elementId  = $request->get('elementId');
-        $objectId   = $request->get('objectId');
+        $code       = $request->query->get('code');
+        $elementId  = $request->query->get('elementId');
+        $objectId   = $request->query->get('objectId');
 
         $admin = $helper->getAdmin($code);
 
@@ -58,9 +58,9 @@ class HelperController extends Controller
     public function retrieveFormFieldElementAction()
     {
         $helper     = $this->getAdminHelper();
-        $code       = $this->get('request')->get('code');
-        $elementId  = $this->get('request')->get('elementId');
-        $objectId   = $this->get('request')->get('objectId');
+        $code       = $this->get('request')->query->get('code');
+        $elementId  = $this->get('request')->query->get('elementId');
+        $objectId   = $this->get('request')->query->get('objectId');
         $admin      = $helper->getAdmin($code);
         $uniqid     = $this->get('request')->query->get('uniqid');
 
@@ -88,11 +88,11 @@ class HelperController extends Controller
         return new Response($extension->renderWidget($childFormBuilder->getForm()->createView()));
     }
 
-    public function getShortObjectDescriptionAction($code = null, $objectId = null, $uniqid = null)
+    public function getShortObjectDescriptionAction()
     {
-        $code       = $code     ?: $this->get('request')->query->get('code');
-        $objectId   = $objectId ?: $this->get('request')->query->get('objectId');
-        $uniqid     = $uniqid   ?: $this->get('request')->get('uniqid');
+        $code       = $this->get('request')->query->get('code');
+        $objectId   = $this->get('request')->query->get('objectId');
+        $uniqid     = $this->get('request')->query->get('uniqid');
 
         $admin  = $this->container->get('sonata.admin.pool')->getInstance($code);
         if ($uniqid) {