Przeglądaj źródła

remove default value for method argument

It makes no sense to have a default value if the arguments after have no
default value.
Grégoire Paris 10 lat temu
rodzic
commit
b52711dd19
2 zmienionych plików z 12 dodań i 1 usunięć
  1. 1 1
      Builder/DatagridBuilderInterface.php
  2. 11 0
      UPGRADE-2.4.md

+ 1 - 1
Builder/DatagridBuilderInterface.php

@@ -28,7 +28,7 @@ interface DatagridBuilderInterface extends BuilderInterface
      *
      *
      * @return void
      * @return void
      */
      */
-    public function addFilter(DatagridInterface $datagrid, $type = null, FieldDescriptionInterface $fieldDescription, AdminInterface $admin);
+    public function addFilter(DatagridInterface $datagrid, $type, FieldDescriptionInterface $fieldDescription, AdminInterface $admin);
 
 
     /**
     /**
      * @param \Sonata\AdminBundle\Admin\AdminInterface $admin
      * @param \Sonata\AdminBundle\Admin\AdminInterface $admin

+ 11 - 0
UPGRADE-2.4.md

@@ -0,0 +1,11 @@
+UPGRADE FROM 2.3 to 2.4
+=======================
+
+### Dependencies
+
+You will need to follow the dependencies upgrade instructions.
+
+## Datagrid builders
+
+If you have implemented a custom datagrid builder, you must adapt the signature
+of its `addFilter` method to match the one in `DatagridBuilderInterface` again.