Bladeren bron

Log signal name used to kill process at debug level.

Chris McDonough 19 jaren geleden
bovenliggende
commit
3ebe515d1a
3 gewijzigde bestanden met toevoegingen van 12 en 5 verwijderingen
  1. 2 0
      CHANGES.txt
  2. 4 2
      src/supervisor/supervisord.py
  3. 6 3
      src/supervisor/tests.py

+ 2 - 0
CHANGES.txt

@@ -1,5 +1,7 @@
 Next
 
+  - Log signal name used to kill processes at debug level.
+
   - supervisorctl "tail -f" didn't work with supervisorctl sections
     configured with an absolute unix:// URL
 

+ 4 - 2
src/supervisor/supervisord.py

@@ -317,8 +317,10 @@ class Subprocess:
             self.options.logger.debug(msg)
             return msg
         try:
-            self.options.logger.debug('killing %s (pid %s)' % (self.config.name,
-                                                               self.pid))
+            self.options.logger.debug('killing %s (pid %s) with signal %s'
+                                      % (self.config.name,
+                                         self.pid,
+                                         signame(sig)))
             self.killing = 1
             self.delay = now + self.config.stopwaitsecs
             self.options.kill(self.pid, sig)

+ 6 - 3
src/supervisor/tests.py

@@ -1339,7 +1339,8 @@ class SubprocessTests(unittest.TestCase):
         instance.stop()
         self.assertEqual(instance.administrative_stop, 1)
         self.failUnless(instance.delay)
-        self.assertEqual(options.logger.data[0], 'killing test (pid 11)')
+        self.assertEqual(options.logger.data[0], 'killing test (pid 11) with '
+                         'signal SIGTERM')
         self.assertEqual(instance.killing, 1)
         self.assertEqual(options.kills[11], signal.SIGTERM)
 
@@ -1359,7 +1360,8 @@ class SubprocessTests(unittest.TestCase):
         instance = self._makeOne(options, config)
         instance.pid = 11
         instance.kill(signal.SIGTERM)
-        self.assertEqual(options.logger.data[0], 'killing test (pid 11)')
+        self.assertEqual(options.logger.data[0], 'killing test (pid 11) with '
+                         'signal SIGTERM')
         self.failUnless(options.logger.data[1].startswith(
             'unknown problem killing test'))
         self.assertEqual(instance.killing, 0)
@@ -1370,7 +1372,8 @@ class SubprocessTests(unittest.TestCase):
         instance = self._makeOne(options, config)
         instance.pid = 11
         instance.kill(signal.SIGTERM)
-        self.assertEqual(options.logger.data[0], 'killing test (pid 11)')
+        self.assertEqual(options.logger.data[0], 'killing test (pid 11) with '
+                         'signal SIGTERM')
         self.assertEqual(instance.killing, 1)
         self.assertEqual(options.kills[11], signal.SIGTERM)