فهرست منبع

supervisor.sendRemoteCommEvent() should set the return value to True.

Mike Naberezny 16 سال پیش
والد
کامیت
63e09af293
2فایلهای تغییر یافته به همراه5 افزوده شده و 2 حذف شده
  1. 1 0
      src/supervisor/rpcinterface.py
  2. 4 2
      src/supervisor/tests/test_rpcinterfaces.py

+ 1 - 0
src/supervisor/rpcinterface.py

@@ -776,6 +776,7 @@ class SupervisorNamespaceRPCInterface:
             events.RemoteCommunicationEvent(type, data)
         )
         
+        return True
 
 def make_allfunc(processes, predicate, func, **extra_kwargs):
     """ Return a closure representing a function that calls a

+ 4 - 2
src/supervisor/tests/test_rpcinterfaces.py

@@ -1592,11 +1592,12 @@ class SupervisorNamespaceXMLRPCInterfaceTests(TestBase):
         
         try:
             events.callbacks[:] = [(events.RemoteCommunicationEvent, callback)]
-            interface.sendRemoteCommEvent('foo', 'bar')
+            result = interface.sendRemoteCommEvent('foo', 'bar')
         finally:
             events.callbacks[:] = []
             events.clear()
 
+        self.assertTrue(result)
         self.assertEqual(len(L), 1)
         event = L[0]                                     
         self.assertEqual(event.type, 'foo')
@@ -1614,11 +1615,12 @@ class SupervisorNamespaceXMLRPCInterfaceTests(TestBase):
         
         try:
             events.callbacks[:] = [(events.RemoteCommunicationEvent, callback)]
-            interface.sendRemoteCommEvent(u'fi\xed once', u'fi\xed twice')
+            result = interface.sendRemoteCommEvent(u'fi\xed once', u'fi\xed twice')
         finally:
             events.callbacks[:] = []
             events.clear()
 
+        self.assertTrue(result)
         self.assertEqual(len(L), 1)
         event = L[0]                                     
         self.assertEqual(event.type, 'fi\xc3\xad once')