Browse Source

It's unsigned.

Chris McDonough 17 years ago
parent
commit
a6703fa203
2 changed files with 2 additions and 1 deletions
  1. 1 1
      src/supervisor/datatypes.py
  2. 1 0
      src/supervisor/tests/test_datatypes.py

+ 1 - 1
src/supervisor/datatypes.py

@@ -72,7 +72,7 @@ def list_of_exitcodes(arg):
     try:
     try:
         vals = list_of_ints(arg)
         vals = list_of_ints(arg)
         for val in vals:
         for val in vals:
-            if val > 255:
+            if (val > 255) or (val < 0):
                 raise 'Invalid exit code "%s"' % val
                 raise 'Invalid exit code "%s"' % val
         return vals
         return vals
     except:
     except:

+ 1 - 0
src/supervisor/tests/test_datatypes.py

@@ -79,6 +79,7 @@ class DatatypesTest(unittest.TestCase):
         self.assertEqual(vals, [1])
         self.assertEqual(vals, [1])
         self.assertRaises(ValueError, datatypes.list_of_exitcodes, 'a,b,c')
         self.assertRaises(ValueError, datatypes.list_of_exitcodes, 'a,b,c')
         self.assertRaises(ValueError, datatypes.list_of_exitcodes, '1024')
         self.assertRaises(ValueError, datatypes.list_of_exitcodes, '1024')
+        self.assertRaises(ValueError, datatypes.list_of_exitcodes, '-1,1')
 
 
     def test_hasattr_automatic(self):
     def test_hasattr_automatic(self):
         datatypes.Automatic
         datatypes.Automatic