merged branch jalliot/assets-install-ignore-vcs (PR #2026)

Commits
-------

24bacdc Ignore VCS files in assets:install command (closes #2025)

Discussion
----------

Ignore VCS files in assets:install command (closes #2025)

---------------------------------------------------------------------------

by stloyd at 2011/08/25 06:10:22 -0700

`ignoreVCS` is set to `true` by default, AFAIK also `getIterator()` is not needed.

---------------------------------------------------------------------------

by jalliot at 2011/08/25 06:30:32 -0700

@stloyd I knew about ``ignoreVCS`` defaulting to ``true`` but I thought it made it clearer but you're right it's not really useful.
As for ``getIterator`` I thought the conversion couldn't be made automatically on a method call like here but apparently it works so I changed it.
Thanks.

---------------------------------------------------------------------------

by tiagojsag at 2011/08/25 08:41:02 -0700

This approach creates another problem: the already existing VCS files are deleted when the command is executed, which makes at least SVN throw errors.

---------------------------------------------------------------------------

by jalliot at 2011/08/25 08:50:55 -0700

@tiagojsag If you remove the call to ``remove`` on line 83, does everything work?
Because I'm not really sure we need to remove the entire dir first since ``mirror`` should be able to adapt itself.

BTW, wouldn't it be better if you didn't commit the ``web/bundles`` dir in your SVN and instead ask to call the ``assets:install`` command each time?

---------------------------------------------------------------------------

by stof at 2011/08/25 08:58:16 -0700

Great news about SVN: the incoming 1.7 version stops adding a ``.svn`` folder in every directory but uses a single one at the root of the project (like git does for instance), solving this sort of issues about copying files :)

@tiagojsag this command has always removed the old asset folders before copying the new ones, and there is not real mean to do otherwise by keeping things simple. You could consider ignoring the ``vendor/bundles`` folder in the SVN and running the command when doing checkout (thus allowing devs to use symlinks if they want)

---------------------------------------------------------------------------

by tiagojsag at 2011/08/25 09:01:39 -0700

yes, that was the solution I was using before submitting this bug report. I also agree that it's the simplest and fastest way to address this, provided that docs get updated, so that no one spends their time trying to figure out why files are not synced with their svn repo.

---------------------------------------------------------------------------

by jalliot at 2011/08/25 09:03:11 -0700

@stof That's really great to hear!
But still this PR should be merged to avoid legacy files from current versions of SVN or other VCS.

---------------------------------------------------------------------------

by stof at 2011/08/25 09:04:31 -0700

@jalliot sure. My comment was mainly about the opposite issue raised by @tiagojsag

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php

@@ -16,6 +16,7 @@ use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Output\Output;
+use Symfony\Component\Finder\Finder;
 
 /**
  * Command that places bundle web assets into a given directory.
@@ -85,7 +86,8 @@ EOT
                     $filesystem->symlink($originDir, $targetDir);
                 } else {
                     $filesystem->mkdir($targetDir, 0777);
-                    $filesystem->mirror($originDir, $targetDir);
+                    // We use a custom iterator to ignore VCS files
+                    $filesystem->mirror($originDir, $targetDir, Finder::create()->in($originDir));
                 }
             }
         }