[Form] Fixed date handling classes to use server timezone by default

src/Symfony/Component/Form/DateField.php

@@ -38,8 +38,8 @@ use Symfony\Component\Form\ValueTransformer\DateTimeToArrayTransformer;
  *  * days:           An array of days for the day select tag.
  *
  *  * format:         The date format type to use for displaying the data. Default: medium.
- *  * data_timezone:  The timezone of the data. Default: UTC.
- *  * user_timezone:  The timezone of the user entering a new value. Default: UTC.
+ *  * data_timezone:  The timezone of the data. Default: server timezone.
+ *  * user_timezone:  The timezone of the user entering a new value. Default: server timezone.
  *
  */
 class DateField extends HybridField
@@ -113,8 +113,8 @@ class DateField extends HybridField
         $this->addOption('days', range(1, 31));
 
         $this->addOption('format', self::MEDIUM, self::$formats);
-        $this->addOption('data_timezone', 'UTC');
-        $this->addOption('user_timezone', 'UTC');
+        $this->addOption('data_timezone', date_default_timezone_get());
+        $this->addOption('user_timezone', date_default_timezone_get());
 
         $this->formatter = new \IntlDateFormatter(
             \Locale::getDefault(),

src/Symfony/Component/Form/DateTimeField.php

@@ -103,8 +103,8 @@ class DateTimeField extends Form
         $this->addOption('minutes', range(0, 59));
         $this->addOption('seconds', range(0, 59));
 
-        $this->addOption('data_timezone', 'UTC');
-        $this->addOption('user_timezone', 'UTC');
+        $this->addOption('data_timezone', date_default_timezone_get());
+        $this->addOption('user_timezone', date_default_timezone_get());
         $this->addOption('date_format', DateField::MEDIUM, self::$dateFormats);
 
         $this->add(new DateField('date', array(

src/Symfony/Component/Form/TimeField.php

@@ -85,8 +85,8 @@ class TimeField extends Form
         $this->addOption('minutes', range(0, 59));
         $this->addOption('seconds', range(0, 59));
 
-        $this->addOption('data_timezone', 'UTC');
-        $this->addOption('user_timezone', 'UTC');
+        $this->addOption('data_timezone', date_default_timezone_get());
+        $this->addOption('user_timezone', date_default_timezone_get());
 
         if ($this->getOption('widget') == self::INPUT) {
             $this->add(new TextField('hour', array('max_length' => 2)));

src/Symfony/Component/Form/ValueTransformer/DateTimeToArrayTransformer.php

@@ -32,8 +32,8 @@ class DateTimeToArrayTransformer extends BaseDateTimeTransformer
      */
     protected function configure()
     {
-        $this->addOption('input_timezone', 'UTC');
-        $this->addOption('output_timezone', 'UTC');
+        $this->addOption('input_timezone', date_default_timezone_get());
+        $this->addOption('output_timezone', date_default_timezone_get());
         $this->addOption('pad', false);
         $this->addOption('fields', array('year', 'month', 'day', 'hour', 'minute', 'second'));
 

src/Symfony/Component/Form/ValueTransformer/DateTimeToStringTransformer.php

@@ -27,8 +27,8 @@ class DateTimeToStringTransformer extends Configurable implements ValueTransform
      */
     protected function configure()
     {
-        $this->addOption('input_timezone', 'UTC');
-        $this->addOption('output_timezone', 'UTC');
+        $this->addOption('input_timezone', date_default_timezone_get());
+        $this->addOption('output_timezone', date_default_timezone_get());
         $this->addOption('format', 'Y-m-d H:i:s');
 
         parent::configure();

src/Symfony/Component/Form/ValueTransformer/DateTimeToTimestampTransformer.php

@@ -27,8 +27,8 @@ class DateTimeToTimestampTransformer extends Configurable implements ValueTransf
      */
     protected function configure()
     {
-        $this->addOption('input_timezone', 'UTC');
-        $this->addOption('output_timezone', 'UTC');
+        $this->addOption('input_timezone', date_default_timezone_get());
+        $this->addOption('output_timezone', date_default_timezone_get());
 
         parent::configure();
     }

tests/Symfony/Tests/Component/Form/DateFieldTest.php

@@ -25,7 +25,12 @@ class DateFieldTest extends DateTimeTestCase
 
     public function testSubmit_fromInput_dateTime()
     {
-        $field = new DateField('name', array('widget' => 'input', 'type' => DateField::DATETIME));
+        $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
+            'widget' => 'input',
+            'type' => DateField::DATETIME,
+        ));
 
         $field->submit('2.6.2010');
 
@@ -35,7 +40,12 @@ class DateFieldTest extends DateTimeTestCase
 
     public function testSubmit_fromInput_string()
     {
-        $field = new DateField('name', array('widget' => 'input', 'type' => DateField::STRING));
+        $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
+            'widget' => 'input',
+            'type' => DateField::STRING,
+        ));
 
         $field->submit('2.6.2010');
 
@@ -45,7 +55,12 @@ class DateFieldTest extends DateTimeTestCase
 
     public function testSubmit_fromInput_timestamp()
     {
-        $field = new DateField('name', array('widget' => 'input', 'type' => DateField::TIMESTAMP));
+        $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
+            'widget' => 'input',
+            'type' => DateField::TIMESTAMP,
+        ));
 
         $field->submit('2.6.2010');
 
@@ -78,7 +93,11 @@ class DateFieldTest extends DateTimeTestCase
 
     public function testSubmit_fromChoice()
     {
-        $field = new DateField('name', array('widget' => DateField::CHOICE));
+        $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
+            'widget' => DateField::CHOICE,
+        ));
 
         $input = array(
             'day' => '2',
@@ -96,7 +115,12 @@ class DateFieldTest extends DateTimeTestCase
 
     public function testSubmit_fromChoice_empty()
     {
-        $field = new DateField('name', array('widget' => DateField::CHOICE, 'required' => false));
+        $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
+            'widget' => DateField::CHOICE,
+            'required' => false,
+        ));
 
         $input = array(
             'day' => '',
@@ -128,6 +152,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsYearWithinRange_returnsTrueIfWithin()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'input',
             'years' => array(2010, 2011),
         ));
@@ -140,6 +166,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsYearWithinRange_returnsTrueIfEmpty()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'input',
             'years' => array(2010, 2011),
         ));
@@ -152,6 +180,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsYearWithinRange_returnsTrueIfEmpty_choice()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'choice',
             'years' => array(2010, 2011),
         ));
@@ -168,6 +198,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsYearWithinRange_returnsFalseIfNotContained()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'input',
             'years' => array(2010, 2012),
         ));
@@ -180,6 +212,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsMonthWithinRange_returnsTrueIfWithin()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'input',
             'months' => array(6, 7),
         ));
@@ -192,6 +226,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsMonthWithinRange_returnsTrueIfEmpty()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'input',
             'months' => array(6, 7),
         ));
@@ -204,6 +240,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsMonthWithinRange_returnsTrueIfEmpty_choice()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'choice',
             'months' => array(6, 7),
         ));
@@ -220,6 +258,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsMonthWithinRange_returnsFalseIfNotContained()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'input',
             'months' => array(6, 8),
         ));
@@ -232,6 +272,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsDayWithinRange_returnsTrueIfWithin()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'input',
             'days' => array(6, 7),
         ));
@@ -244,6 +286,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsDayWithinRange_returnsTrueIfEmpty()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'input',
             'days' => array(6, 7),
         ));
@@ -256,6 +300,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsDayWithinRange_returnsTrueIfEmpty_choice()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'choice',
             'days' => array(6, 7),
         ));
@@ -272,6 +318,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsDayWithinRange_returnsFalseIfNotContained()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'input',
             'days' => array(6, 8),
         ));
@@ -284,6 +332,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsPartiallyFilled_returnsFalseIfInput()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'input',
         ));
 
@@ -295,6 +345,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsPartiallyFilled_returnsFalseIfChoiceAndCompletelyEmpty()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'choice',
         ));
 
@@ -310,6 +362,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsPartiallyFilled_returnsFalseIfChoiceAndCompletelyFilled()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'choice',
         ));
 
@@ -325,6 +379,8 @@ class DateFieldTest extends DateTimeTestCase
     public function testIsPartiallyFilled_returnsTrueIfChoiceAndDayEmpty()
     {
         $field = new DateField('name', array(
+            'data_timezone' => 'UTC',
+            'user_timezone' => 'UTC',
             'widget' => 'choice',
         ));