[DoctrineMongoDBBundle] Removing the "default_connection" DI parameter, which was never used as a parameter. Now cleaning up connections creation in the DI extension class.

src/Symfony/Bundle/DoctrineMongoDBBundle/DependencyInjection/DoctrineMongoDBExtension.php

@@ -77,8 +77,17 @@ class DoctrineMongoDBExtension extends AbstractDoctrineExtension
         // set some options as parameters and unset them
         $config = $this->overrideParameters($config, $container);
 
-       
-        $this->loadConnections($config, $container);
+        // if no "connections" were given, setup the default connection
+        if (!isset($config['connections']) || !$config['connections']) {
+            $defaultName = $config['default_connection'];
+            $config['connections'] = array($defaultName => array(
+                'server'    => $config['server'],
+                'options'   => $config['options'],
+            ));
+        }
+        // load the connections
+        $this->loadConnections($config['connections'], $container);
+
         $this->loadDocumentManagers($config, $container);
         $this->loadConstraints($config, $container);
     }
@@ -93,7 +102,6 @@ class DoctrineMongoDBExtension extends AbstractDoctrineExtension
     {
         $overrides = array(
             'default_document_manager',
-            'default_connection',
             'proxy_namespace',
             'auto_generate_proxy_classes',
             'hydrator_namespace',
@@ -260,12 +268,11 @@ class DoctrineMongoDBExtension extends AbstractDoctrineExtension
     /**
      * Loads the configured connections.
      *
-     * @param array $config An array of configuration settings
+     * @param array $config An array of connections configurations
      * @param ContainerBuilder $container A ContainerBuilder instance
      */
-    protected function loadConnections(array $config, ContainerBuilder $container)
+    protected function loadConnections(array $connections, ContainerBuilder $container)
     {
-        $connections = $this->getConnections($config, $container);
         foreach ($connections as $name => $connection) {
             $odmConnArgs = array(
                 isset($connection['server']) ? $connection['server'] : null,
@@ -277,28 +284,6 @@ class DoctrineMongoDBExtension extends AbstractDoctrineExtension
         }
     }
 
-    /**
-     * Gets the configured connections.
-     *
-     * @param array $config An array of configuration settings
-     * @param ContainerBuilder $container A ContainerBuilder instance
-     */
-    protected function getConnections(array $config, ContainerBuilder $container)
-    {
-        $defaultConnection = $container->getParameter('doctrine.odm.mongodb.default_connection');
-
-        $connections = array();
-        if (count($config['connections'])) {
-            $configConnections = $config['connections'];
-            foreach ($configConnections as $name => $connection) {
-                $connections[isset($connection['id']) ? $connection['id'] : $name] = $connection;
-            }
-        } else {
-            $connections = array($defaultConnection => $config);
-        }
-        return $connections;
-    }
-
     /**
      * Loads an ODM document managers bundle mapping information.
      *

src/Symfony/Bundle/DoctrineMongoDBBundle/Resources/config/mongodb.xml

@@ -6,7 +6,6 @@
 
   <parameters>
     <parameter key="doctrine.odm.mongodb.default_document_manager">default</parameter>
-    <parameter key="doctrine.odm.mongodb.default_connection">default</parameter>
     <parameter key="doctrine.odm.mongodb.default_database">default</parameter>
     <parameter key="doctrine.odm.mongodb.connection_class">Doctrine\MongoDB\Connection</parameter>
     <parameter key="doctrine.odm.mongodb.configuration_class">Doctrine\ODM\MongoDB\Configuration</parameter>