浏览代码

FD3-522 añado comprobación de variable previo a foreach, no debería retornar error un foreach vacío pero en caso de falla por alguna respuesta rara del find, que no busque realizar iteración.

Maxi Schvindt 7 年之前
父节点
当前提交
7aced66aa3
共有 1 个文件被更改,包括 9 次插入6 次删除
  1. 9 6
      src/FTTHBundle/Controller/REST/ONURESTController.php

+ 9 - 6
src/FTTHBundle/Controller/REST/ONURESTController.php

@@ -150,12 +150,15 @@ class ONURESTController extends RESTController
             $cmd_args['transition'] = "--transition:{$transition}";
             $cmd_args['transition'] = "--transition:{$transition}";
             
             
             $serialNumbers = array();
             $serialNumbers = array();
-            foreach($onus as $onu) {
-                $onuId = $onu->getId();
-                $cmd_args['id'] = "--id:{$onuId}";
-                $serialNumbers[$onuId] = $onu->getPonSerialNumber();
-
-                $this->runCommand('workflow:apply', $cmd_args);
+            if($onus) {
+
+                foreach($onus as $onu) {
+                    $onuId = $onu->getId();
+                    $cmd_args['id'] = "--id:{$onuId}";
+                    $serialNumbers[$onuId] = $onu->getPonSerialNumber();
+                    
+                    $this->runCommand('workflow:apply', $cmd_args);
+                }
             }
             }
 
 
             return array('client' => $id, 'transition' => $transition, "count" => count($onus), 'onus' => $serialNumbers);
             return array('client' => $id, 'transition' => $transition, "count" => count($onus), 'onus' => $serialNumbers);